Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PaddlePaddle] support paddlejob #1675

Merged
merged 17 commits into from
Nov 7, 2022
Merged

[PaddlePaddle] support paddlejob #1675

merged 17 commits into from
Nov 7, 2022

Conversation

kuizhiqing
Copy link
Member

@kuizhiqing kuizhiqing commented Oct 21, 2022 •
edited
Loading

What this PR does / why we need it:

Since stand-alone operator is not preferred, we integrate with the unified one. Discussion goes here kubeflow/community#520.

Thanks to the scaffold and PyTorch implementation, this implementation profits a lot.

Checklist:

  • [v] Docs included if any changes are user facing

@johnugeorge
Copy link
Member

Awesome! Thanks for this @kuizhiqing

@coveralls
Copy link

coveralls commented Oct 21, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3383985883

  • 324 of 894 (36.24%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 39.205%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/register_controller.go 0 3 0.0%
pkg/apis/kubeflow.org/v1/paddlepaddle_validation.go 27 32 84.38%
pkg/apis/kubeflow.org/v1/zz_generated.defaults.go 0 10 0.0%
pkg/controller.v1/paddlepaddle/envvar.go 83 112 74.11%
pkg/apis/kubeflow.org/v1/paddlepaddle_defautls.go 0 46 0.0%
pkg/apis/kubeflow.org/v1/zz_generated.deepcopy.go 0 99 0.0%
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 210 372 56.45%
pkg/apis/kubeflow.org/v1/openapi_generated.go 0 216 0.0%
Totals Coverage Status
Change from base Build 3380673253: -0.5%
Covered Lines: 2662
Relevant Lines: 6790
💛 - Coveralls

terrytangyuan
terrytangyuan reviewed Oct 21, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this! Let us know when it's ready for review.

@johnugeorge
Copy link
Member

Can you add one e2e test in https://github.com/kubeflow/training-operator/tree/master/sdk/python/test/e2e?

@terrytangyuan terrytangyuan marked this pull request as draft October 21, 2022 19:27
@kuizhiqing kuizhiqing marked this pull request as ready for review October 24, 2022 11:33
@kuizhiqing
Copy link
Member Author

kuizhiqing commented Oct 24, 2022 •
edited
Loading

Can you add one e2e test in https://github.com/kubeflow/training-operator/tree/master/sdk/python/test/e2e?

@johnugeorge , e2e test is added and tested locally, plz help rerun the CI.

@kuizhiqing kuizhiqing requested review from terrytangyuan and removed request for johnugeorge, gaocegege and jinchihe October 24, 2022 11:56
@johnugeorge
Copy link
Member

e2e tests failed. Can you try this locally ?

@kuizhiqing
Copy link
Member Author

e2e tests failed. Can you try this locally ?

I did pass the e2e test locally,
image
image
while the CI test errors related to the last 2 commits are quite confused.

@johnugeorge could you give some tips to handle those errors, thx.

@kuizhiqing kuizhiqing requested review from terrytangyuan and removed request for gaocegege November 3, 2022 06:12
@johnugeorge
Copy link
Member

Can you fix the tests?

@johnugeorge
Copy link
Member

/lgtm
/assign @terrytangyuan

@google-oss-prow google-oss-prow bot added the lgtm label Nov 3, 2022
gaocegege
gaocegege reviewed Nov 3, 2022
View reviewed changes
pkg/apis/kubeflow.org/v1/paddlepaddle_types.go
// PaddleJobSingular is the singular for paddleJob.
PaddleJobSingular = "paddlejob"
// PaddleJobFrameworkName is the name of the ML Framework
PaddleJobFrameworkName = "paddle"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this const?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.
Yes, they are referred in the expectation and logger part.

gaocegege
gaocegege reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

@google-oss-prow google-oss-prow bot removed the lgtm label Nov 3, 2022
@kuizhiqing
Copy link
Member Author

@johnugeorge plz help with the CI test.

@kuizhiqing
Copy link
Member Author

@terrytangyuan , PTAL

@terrytangyuan
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 7, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuizhiqing, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 05badc6 into kubeflow:master Nov 7, 2022
@johnugeorge johnugeorge mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@gaocegege gaocegege gaocegege left review comments

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@johnugeorge johnugeorge

@terrytangyuan terrytangyuan

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kuizhiqing @johnugeorge @coveralls @terrytangyuan @gaocegege @tenzen-y